chore: onboard stepsecurity and apply security best practice#99
Open
ali-kafel wants to merge 3 commits into
Open
chore: onboard stepsecurity and apply security best practice#99ali-kafel wants to merge 3 commits into
ali-kafel wants to merge 3 commits into
Conversation
Signed-off-by: StepSecurity Bot <bot@stepsecurity.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem description and solution.
This pull request strengthens the security of our GitHub Actions workflows by hardening the runners and pinning action versions to specific commit SHAs. It also adds explicit permissions for the coverage workflow.
Detail
Changeset
Security hardening of GitHub Actions workflows:
step-security/harden-runneraction to both thelint_and_testandrun_coveragejobs to audit or block outbound calls, reducing the risk of supply chain attacks. [1] [2]run_coveragejob, configured the harden-runner action to block egress except for globally allowed endpoints, and added explicitid-token: writepermissions for improved security and least-privilege operation.Workflow maintenance and reliability:
actions/checkoutaction in both workflows to use a specific commit SHA rather than a version tag, ensuring builds are deterministic and protected from upstream changes. [1] [2]Checklist
yarn test)yarn coverage)docsfolder)yarn lint) and fix any issues?yarn format:check) and fix any issues (yarn format:write)?Testing
Tested using the PR workflows.
Documentation
Optional section.
Link to the doc.